Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve examples/read-only-auth #371

Merged
merged 2 commits into from
Apr 5, 2024
Merged

docs: Improve examples/read-only-auth #371

merged 2 commits into from
Apr 5, 2024

Conversation

silverwind
Copy link
Contributor

@silverwind silverwind commented Mar 29, 2024

Fix multiple issues with this example:

  1. The filenames were confusingly named. read-write.htpasswd did not actually grant read-write access as one might think, only write access. So I renamed these files to read and write to accurately picture what they do.
  2. The sentence "All users in read-only.htpasswd should be in read-write.htpasswd." is incorrect because you never want that, you want the inverse.
  3. Changed mount of read file to ro as well as nginx would never write to it.
  4. Reversed the auth_basic_user_file logic in nginx because there are less read methods than write methods and from security perspective in regards to future HTTP methods, it's better to fail those to the read file than the write file.

@silverwind silverwind changed the title Improve examples/read-only-auth docs: Improve examples/read-only-auth Mar 29, 2024
Copy link
Owner

@Joxit Joxit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your contribution and using my project 😄

@Joxit Joxit merged commit a36e3aa into Joxit:main Apr 5, 2024
1 check passed
@silverwind silverwind deleted the rw branch April 5, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants