Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MaxWhiteList size of proposal #4684

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix storybook error
chrlschwb committed Dec 8, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 3d09cfdf420f4beaef7e3ca764d9c8337e31df16
4 changes: 4 additions & 0 deletions packages/ui/src/mocks/data/proposals.ts
Original file line number Diff line number Diff line change
@@ -212,6 +212,10 @@ export const proposalsPagesChain = (
titleMaxLength: 40,
},

proposalsDiscussion: {
maxWhiteListSize: 20
},

proposalsCodex: {
fundingRequestProposalMaxTotalAmount: joy(166_666),
fundingRequestProposalMaxAccounts: 2,
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react'
import React, { useMemo } from 'react'
import { useFormContext } from 'react-hook-form'
import styled from 'styled-components'

import { useApi } from '@/api/hooks/useApi'
import { CloseButton } from '@/common/components/buttons'
import { InlineToggleWrap, InputComponent, Label, ToggleCheckbox, InputNumber } from '@/common/components/forms'
import { Row } from '@/common/components/Modal'
@@ -15,24 +15,25 @@ import { SelectMember } from '@/memberships/components/SelectMember'
import { Member } from '@/memberships/types'

export const TriggerAndDiscussionStep = () => {
const { api } = useApi()
const { watch, setValue } = useFormContext()

const [discussionWhitelist, isDiscussionClosed, trigger, triggerBlock] = watch([
'triggerAndDiscussion.discussionWhitelist',
'triggerAndDiscussion.isDiscussionClosed',
'triggerAndDiscussion.trigger',
'triggerAndDiscussion.triggerBlock',
])

const addMemberToWhitelist = (member: Member) => {
setValue('triggerAndDiscussion.discussionWhitelist', [...discussionWhitelist, member], { shouldValidate: true })
}
const removeMemberFromWhitelist = (member: Member) => {
setValue(
'triggerAndDiscussion.discussionWhitelist',
discussionWhitelist.filter((whitelistMember: Member) => whitelistMember.id !== member.id),
{ shouldValidate: true }
)
}
const maxWhiteList = api?.consts.proposalsDiscussion.maxWhiteListSize.toNumber() ?? 1

const addMemberToWhitelist = (member: Member) => updateWhitelist([...discussionWhitelist, member])

const removeMemberFromWhitelist = (member: Member) =>
updateWhitelist(discussionWhitelist.filter((m: Member) => m.id !== member.id))

const updateWhitelist = (members: Member[]) =>
setValue('triggerAndDiscussion.discussionWhitelist', members, { shouldValidate: true })

return (
<RowGapBlock gap={24}>
@@ -93,14 +94,19 @@ export const TriggerAndDiscussionStep = () => {
label="Add member to whitelist"
required
inputSize="l"
disabled={discussionWhitelist.length < maxWhiteList ? false : true}
>
<SelectMember
onChange={(member) => addMemberToWhitelist(member)}
filter={(member) =>
!discussionWhitelist.find((whitelistMember: Member) => whitelistMember.id === member.id)
}
disabled={discussionWhitelist.length < maxWhiteList ? false : true}
/>
</InputComponent>
{discussionWhitelist.length >= maxWhiteList && (
<WhitelistMaxinum>Maximum whitelist size of {maxWhiteList} members is reached</WhitelistMaxinum>
)}
<WhitelistContainer>
{discussionWhitelist.map((member: Member) => (
<WhitelistMember key={member.id}>
@@ -144,3 +150,9 @@ const WhitelistRemoveMember = styled(CloseButton)`
height: 16px;
color: ${Colors.Black[900]};
`
const WhitelistMaxinum = styled.div`
background-color: ${Colors.Blue[400]};
padding: 10px 15px;
border-radius: 3px;
color: white;
`