Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#36: update eslint config #59

Closed
wants to merge 5 commits into from
Closed

#36: update eslint config #59

wants to merge 5 commits into from

Conversation

Thisman
Copy link

@Thisman Thisman commented May 15, 2018

#36 , I switched off some rules, because they cannot autofix. We need decide which errors should fixed

@Thisman Thisman self-assigned this May 15, 2018
@xilaraux
Copy link

Nice PR!

@Thisman Thisman added the bug label May 16, 2018
@Thisman
Copy link
Author

Thisman commented May 17, 2018

@PROPHESSOR Let's fix that errors list:

  • consistent-return
  • class-methods-use-this
  • import/no-extraneous-dependencies
  • prefer-const
  • no-undef
  • no-unused-expressions
  • func-names
  • no-shadow ( need refactoring )
  • block-scoped-var ( need refactoring )
  • one-var ( need refactoring )
  • prefer-destructuring
  • prefer-rest-param
  • no-continue
  • no-use-before-define
  • no-var
  • no-multi-assign
  • no-unused-vars
  • no-tabs
  • global-require
  • prefer-spread
  • no-buffer-constructor
  • no-sequences
  • camelcase
  • no-new-wrappers
  • no-dupe-keys
  • no-redeclare ( refactoring )
  • array-callback-return
  • no-unreachable
  • no-cond-assign
  • brace-style
  • no-restricted-globals
  • import/no-unresolved
  • guard-for-in
  • no-lone-blocks
  • no-new-object
  • no-empty
  • no-lonely-if
  • defult-case
  • no-inner-declarations
  • new-cap
  • no-constant-condition
  • no-new-require
  • no-loop-func
  • vars-on-top

@Thisman
Copy link
Author

Thisman commented Jun 28, 2018

@PROPHESSOR what with this PR?

@PROPHESSOR
Copy link
Collaborator

@Thisman
I don't know...
Now eslintrc looks terrible.
I just need to sit down and do it, but not enough time.

@Thisman Thisman closed this Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Thisman Thisman

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thisman @xilaraux @PROPHESSOR