Remove unused timeout parameter from iOS WiFi connection methods

[dawidzawada]

When a user denies the WiFi connection prompt on iOS, the app crashes without any error message. This happens when calling connectToProtectedSSID.

This fixes #424

XCode's catched crash error:

Thread 1: EXC_BAD_ACCESS (code=1, address=0x10)

Root Cause

The iOS implementation includes a timeout parameter that isn't used and isn't defined in TypeScript types:

TypeScript definition:

connectToProtectedSSID(
  ssid: string, 
  password: string, 
  isWEP: boolean, 
  isHidden: boolean
): Promise<void>;

Native method implementation:

RCT_EXPORT_METHOD(connectToProtectedSSID:(NSString*)ssid
                  withPassphrase:(NSString*)passphrase
                  isWEP:(BOOL)isWEP
                  isHidden:(BOOL)isHidden
                  timeout:(nonnull NSNumber *)timeout // Extra parameter
                  resolver:(RCTPromiseResolveBlock)resolve
                  rejecter:(RCTPromiseRejectBlock)reject) {
    [self connectToProtectedSSIDOnce:ssid withPassphrase:passphrase isWEP:isWEP joinOnce:false resolver:resolve rejecter:reject];
}

When connectToProtectedSSID is called without timeout, connectToProtectedSSIDOnce does not receives rejecter argument, then when user's cancels on connection prompt calling reject in connectToProtectedSSIDOnce causes crash.

My fix proposition is to remove timeout argument since it's not used on iOS implementation, thanks to that error in connectToProtectedSSIDOnce method can be reject properly and return an error to JS thread that can be properly handled.

Let me know what you think!

[JuanSeBestia]

🎉 This PR is included in version 4.13.3 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀