Implements Indian and Chinese States/Provinces in address #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-tudor
reviewed
Dec 6, 2024
RafalOzogJudopay
force-pushed
the
CT-3016-introduces-state-into-indian-addresses
branch
from
f2baa9b to
0dc9ecf
Compare
RafalOzogJudopay
changed the title
RafalOzogJudopay
force-pushed
the
CT-3016-introduces-state-into-indian-addresses
branch
3 times, most recently
from
772ffda to
14d38c9
Compare
RafalOzogJudopay
force-pushed
the
CT-3016-introduces-state-into-indian-addresses
branch
from
1a3c765 to
deec266
Compare
|
| @@ -52,7 +56,7 @@ - (instancetype)initWithDictionary:(NSDictionary *)dict { | |||
|
|
|||
| @implementation JPStateList | |||
|
|
|||
| + (instancetype)usStateList { | |||
| + (nullable instancetype)usStatesList { | |||
There was a problem hiding this comment.
No need for nullable in implementation (.m) files
| @@ -549,12 +549,20 @@ - (void)updateBillingCountryViewModelForInput:(NSString *)input showError:(BOOL) | |||
| [self updateBillingStateViewModelForInput:@"" showError:showError]; | |||
|
|
|||
| if (country.isUSA) { | |||
| stateViewModel.options = JPStateList.usStateList.states; | |||
| stateViewModel.options = JPStateList.usStatesList ? JPStateList.usStatesList.states : @[]; | |||
There was a problem hiding this comment.
can we simply stateViewModel.options = JPStateList.usStatesList.states ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Demo:
demo.mov