Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code supporting @from_network and @pipeline. #932

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Sep 22, 2023

Using the macros currently warns the user that they are deprecated. This PR removes them.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07% ⚠️

Comparison is base (a394358) 86.27% compared to head (8788e41) 86.21%.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           for-a-0-point-22-release     #932      +/-   ##
============================================================
- Coverage                     86.27%   86.21%   -0.07%     
============================================================
  Files                            32       27       -5     
  Lines                          2834     2531     -303     
============================================================
- Hits                           2445     2182     -263     
+ Misses                          389      349      -40     
Files Changed Coverage Δ
src/MLJBase.jl 100.00% <ø> (ø)
src/composition/learning_networks/replace.jl 92.95% <ø> (-1.98%) ⬇️
src/machines.jl 90.45% <ø> (ø)
src/operations.jl 90.38% <100.00%> (+0.38%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom ablaom mentioned this pull request Sep 22, 2023
4 tasks
@ablaom ablaom merged commit fa955a5 into for-a-0-point-22-release Sep 22, 2023
4 of 5 checks passed
@ablaom ablaom deleted the remove-deprecated-stuff branch September 22, 2023 02:52
This was referenced Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant