Nested block indexing #482
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables nested block indexing by generalizing
BlockIndex
to allow indices that aren't integers, for example:As an alternative to just generalizing
BlockIndex
, maybe we could define a new type such asGenericBlockIndex
and then makeBlockIndex
a type alias for that with the indices restricted to integers. I don't have a strong opinion about that but this design was simpler and I don't see much advantage one way or another.Related to #49 and #446, though note that in this PR the nested block structure isn't reflected in the axes, which would be required for more systematic support of nested block structures. This PR is split off from #462.