-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overhaul constructors #19
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 98.21% 89.83% -8.39%
==========================================
Files 3 3
Lines 56 59 +3
==========================================
- Hits 55 53 -2
- Misses 1 6 +5
Continue to review full report at Codecov.
|
@oschulz I've been using ElasticArrays.jl quite a bit but ran into a few oddities. I ended up copying out |
Sure, should still be possible to understand what you did. Are the changes non-breaking? |
Btw, @colinxs, if you use ElasticArrays.jl (glad that you like it and want to help improve it!) in an array-of-arrays semantic context, you may also be interested in ArraysOfArrays.jl. |
A primary design goal for |
Awesome! I'll at least break up the commits so it's easier to parse. Everything should be non-breaking except for support for broadcasting that I added and which I'll put in a separate PR.
I'm actually already a fan of ArraysOfArrays.jl :). I was the one who opened JuliaArrays/ArraysOfArrays.jl#2 awhile back. In case you missed it, I recently posted a solution to that PR. |
Sounds, great, thanks for lending a hand!
Oh, right, that was you! Sorry, wanted to get that done a long time ago, was just overloaded. |
Following the implementation of
Array
:undef
constructor with size specified as aTuple
convert
in terms of the above.