Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overhaul constructors #19

Merged
merged 1 commit into from
Apr 11, 2020
Merged

overhaul constructors #19

merged 1 commit into from
Apr 11, 2020

Conversation

colinxs
Copy link
Contributor

@colinxs colinxs commented Apr 10, 2020

Following the implementation of Array:

  1. Adds undef constructor with size specified as a Tuple
  2. Adds constructors that allow type parameters to be specified
  3. Defines convert in terms of the above.

@codecov-io
Copy link

Codecov Report

Merging #19 into master will decrease coverage by 8.38%.
The diff coverage is 76.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   98.21%   89.83%   -8.39%     
==========================================
  Files           3        3              
  Lines          56       59       +3     
==========================================
- Hits           55       53       -2     
- Misses          1        6       +5     
Impacted Files Coverage Δ
src/elasticarray.jl 89.28% <76.00%> (-8.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8de994...deecb9b. Read the comment docs.

@colinxs
Copy link
Contributor Author

colinxs commented Apr 10, 2020

@oschulz I've been using ElasticArrays.jl quite a bit but ran into a few oddities. I ended up copying out ElasticArray to a package I use internally and fixing things there because it was easiest at the time, but I was hoping to port those changes back to ElasticArrays.jl. For the sake of laziness would you mind if the remaining changes came rolled up into one PR?

@oschulz
Copy link
Collaborator

oschulz commented Apr 11, 2020

For the sake of laziness would you mind if the remaining changes came rolled up into one PR

Sure, should still be possible to understand what you did. Are the changes non-breaking?

@oschulz
Copy link
Collaborator

oschulz commented Apr 11, 2020

Btw, @colinxs, if you use ElasticArrays.jl (glad that you like it and want to help improve it!) in an array-of-arrays semantic context, you may also be interested in ArraysOfArrays.jl.

@oschulz
Copy link
Collaborator

oschulz commented Apr 11, 2020

A primary design goal for ElasticArray was actually to act as a backend for ArraysOfArrays.ArrayOfSimilarArrays.

@oschulz oschulz merged commit 119b7d5 into JuliaArrays:master Apr 11, 2020
@colinxs
Copy link
Contributor Author

colinxs commented Apr 14, 2020

@oschulz

Sure, should still be possible to understand what you did. Are the changes non-breaking?

Awesome! I'll at least break up the commits so it's easier to parse. Everything should be non-breaking except for support for broadcasting that I added and which I'll put in a separate PR.

Btw, @colinxs, if you use ElasticArrays.jl (glad that you like it and want to help improve it!) in an array-of-arrays semantic context, you may also be interested in ArraysOfArrays.jl.

I'm actually already a fan of ArraysOfArrays.jl :). I was the one who opened JuliaArrays/ArraysOfArrays.jl#2 awhile back. In case you missed it, I recently posted a solution to that PR.

@oschulz
Copy link
Collaborator

oschulz commented Apr 14, 2020

Sounds, great, thanks for lending a hand!

I was the one who opened JuliaArrays/ArraysOfArrays.jl#2 awhile back

Oh, right, that was you! Sorry, wanted to get that done a long time ago, was just overloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants