Stop using internals: Base.copymutable [NFC]
#1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thchr
reviewed
Nov 13, 2023
Co-authored-by: Thomas Christensen <[email protected]>
|
Why did you replace |
|
Because julia> @less Base.copymutable([1,2,3])
function copymutable(a::AbstractArray)
@_propagate_inbounds_meta
copyto!(similar(a), a)
end
copymutable(itr) = collect(itr) |
|
I see, it makes sense. |
mateuszbaran
approved these changes
Nov 16, 2023
thchr
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I inlined the implementations to the call sites which, remarkably, improves concision.