Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't import require_one_based_indexing from StaticArraysCore #1279

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Sep 29, 2024

This is not being used anywhere in the package, and StaticArraysCore now uses the Base function instead of defining their own. This means precompilation is currently broken for this package without removing this import.

@jishnub
Copy link
Member Author

jishnub commented Oct 20, 2024

Bump

@mateuszbaran mateuszbaran merged commit 899fb0a into master Oct 20, 2024
26 checks passed
@mateuszbaran mateuszbaran deleted the jishnub/require_one_based_indexing branch October 20, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants