Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let count, sum, and prod take an init kwarg #1281

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

thchr
Copy link
Collaborator

@thchr thchr commented Oct 18, 2024

Allows StaticArrays' count implementation to take an init kwarg, just as Base.count (since Julia v1.6).

Also bumps StaticArrays to v1.9.8, to enable releasing the fix.

EDIT: Updated to also add init to prod and sum, fixing #1119 in the process.

 - `Base.count` allows the `init` kwarg since v1.6
 - bump StaticArrays to 1.9.8
@thchr thchr changed the title Let count take an init kwarg Let count, sum, and prod take an init kwarg Oct 18, 2024
Copy link
Collaborator

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The invalidation action is failing but that appears to be due to some changes in Julia 1.11. Maybe we should run that action on Julia 1.10 for now or report the issue somewhere?

@thchr
Copy link
Collaborator Author

thchr commented Oct 21, 2024

Do you want me to change CI to do that here?

EDIT: I actually don't understand why the invalidations action runs on Julia 1.11, cf.:

runs-on: ubuntu-latest
steps:
- uses: julia-actions/setup-julia@v2
with:
version: '1'

Shouldn't version: '1' still refer to v1.10? v1.11 hasn't been released yet, right?
My bad, it has been released for a few weeks. I guess we could change the version to lts instead?

@mateuszbaran
Copy link
Collaborator

Yes, I think it would be a good idea to change CI script to lts here.

@mateuszbaran mateuszbaran merged commit b2f2fb0 into JuliaArrays:master Oct 21, 2024
24 checks passed
@thchr thchr deleted the count-init branch October 21, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants