Define mapfoldl/foldl for static arrays #750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some improvements discussed in #702 (comment):
_InitialValue
works and explain some idea behind it._InitialValue
instead of passing aroundkw.data :: NamedTuple
._InitialValue
to collapse the foldl implementations with and withoutinit
into one.mapfoldl
andfoldl
on static arrays:_mapreduce
to_mapfoldl
._mapreduce
back as an alias to_mapfoldl
.sum
) wrapping reduce can just call_mapreduce
._mapreduce
Discussion: should we use divide-and-conquer reduce for instruction-level parallelism? #748.Base.mapfoldl
andBase.foldl
as a simple wrapper of_mapfoldl
.It's not a tiny diff but mostly all the changes are simple refactoring.