Define mapfoldl/foldl for static arrays #750
Merged
+88
−72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some improvements discussed in #702 (comment):
_InitialValueworks and explain some idea behind it._InitialValueinstead of passing aroundkw.data :: NamedTuple._InitialValueto collapse the foldl implementations with and withoutinitinto one.mapfoldlandfoldlon static arrays:_mapreduceto_mapfoldl._mapreduceback as an alias to_mapfoldl.sum) wrapping reduce can just call_mapreduce._mapreduceDiscussion: should we use divide-and-conquer reduce for instruction-level parallelism? #748.Base.mapfoldlandBase.foldlas a simple wrapper of_mapfoldl.It's not a tiny diff but mostly all the changes are simple refactoring.