-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added gcc09 and vcg04 #13
Conversation
@giordano any clue why these travis builds are randomly failing? |
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 96.15% 97.69% +1.53%
==========================================
Files 3 3
Lines 104 130 +26
==========================================
+ Hits 100 127 +27
+ Misses 4 3 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are looking really good, and it's always great to add more models! Thanks. I think it's worth it to remove the polynomials within the invum functions, but keep the polynomial references in the ccm89
. Basically, unless the polynomials are being passed to a funciton, we should use @evalpoly
to avoid the allocation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now. @mileslucas?
Cirrus is constantly failing across all projects I watch, I think we should just remove it... |
Looks good as far as I can tell too. I guess let’s merge this and fix CI in another PR |
Shall we merge this? |
This PR is complete from my side. 😃 |
Added gcc09 and vcg04 as mentioned in #10.