Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional import of Base.isfull #896

Merged

Conversation

KronosTheLate
Copy link
Contributor

As suggested in this comment in #894

@oxinabox
Copy link
Member

oxinabox commented Feb 7, 2024

Will merge once JuliaLang/julia#53159 is merged

@CameronBieganek
Copy link

This might qualify as punning. The docstring for Base.isfull is very specific to Channels---it does not provide a generic definition of isfull that could also apply to DataStructures.CircularBuffer.

@vtjnash
Copy link
Contributor

vtjnash commented Feb 10, 2024

Do you want to suggest a change on the Base PR? I think this function is very much the same concept as a general queue/stack implementation concept

@KronosTheLate
Copy link
Contributor Author

Will merge once JuliaLang/julia#53159 is merged

That PR got merged yesterday.

@oxinabox oxinabox merged commit 77692ea into JuliaCollections:master Mar 5, 2024
10 checks passed
@oxinabox
Copy link
Member

oxinabox commented Mar 5, 2024

merged and backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants