Skip to content

Fix append!(l1, l2) for empty MutableLinkedList l2 #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix append!(l1, l2) for empty MutableLinkedList l2 #942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/mutable_list.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ function Base.setindex!(l::MutableLinkedList{T}, data, idx::Int) where T
end

function Base.append!(l1::MutableLinkedList{T}, l2::MutableLinkedList{T}) where T
isempty(l2) && return l1
l1.node.prev.next = l2.node.next # l1's last's next is now l2's first
l2.node.prev.next = l1.node # l2's last's next is now l1.node
l2.node.next.prev = l1.node.prev # l2's first's prev is now l1's last
Expand Down
8 changes: 8 additions & 0 deletions test/test_mutable_list.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,14 @@
push!(l4, n+1:2n...)
@test l4 == MutableLinkedList{Int}(1:2n...)
@test collect(l4) == collect(MutableLinkedList{Int}(1:2n...))
l5 = copy(l)
l6 = MutableLinkedList{Int}()
append!(l5, l6)
@test collect(l5) == 1:2n
@test l6 == MutableLinkedList{Int}()
append!(l6, l5)
@test collect(l6) == 1:2n
@test l5 == MutableLinkedList{Int}()
end

@testset "delete" begin
Expand Down
Loading