Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of eval #59

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Get rid of eval #59

wants to merge 7 commits into from

Commits on Oct 28, 2020

  1. Get rid of eval

    Fix #48, at the cost of putting the variable in a poorly-performing global.
    
    Not sure if this is acceptable. It's frustrating that Julia seemingly lacks the tools to deal with
    this elegantly.
    
    - If `const` worked in a local function, we'd just put `const` and be done with it.
    - If `typeconst` existed for global variables, that would work too.
    
    Memoization.jl uses generated functions, which causes other problems. And it feels like the
    wrong solution too.
    cstjean committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    09b8348 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2020

  1. Use local directive so that it's also performant

    at the global scope
    cstjean committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    88c8c6f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cc4b00a View commit details
    Browse the repository at this point in the history
  3. Support memoize_cache too

    cstjean committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    72ab0cd View commit details
    Browse the repository at this point in the history
  4. Fix the broken finalized test

    cstjean committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    7d5f2f4 View commit details
    Browse the repository at this point in the history
  5. Comment

    cstjean committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    0d703de View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2021

  1. Factor out try_empty_cache.

    It makes the macro expansion much more palatable
    cstjean committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    c596fdb View commit details
    Browse the repository at this point in the history