Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set suppress_errors=false in Franklin build #610

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

staticfloat
Copy link
Contributor

@staticfloat staticfloat commented Jul 10, 2024

We broke the JuliaCon website on the first day because an error was suppressed. The error had been live for a while, but a change to surrounding code caused it to move from minor annoyance to catastrophic. This moves us to a stricter mode where such errors are not allowed at all.

Briefly Describe your changes

Checklist for merge

  • I built the website locally and tested it using Franklin.serve()
  • All CI checks have passed and you have tested the online version (click on the list of checks and click Build and Deploy / Preview to see the preview)
  • Somebody else reviewed my changes (use your best judgement if you need to merge quickly

After merge

  • Closed relevant issues

We broke the JuliaCon website on the first day because an error was suppressed.  The error had been live for a while, but a change to surrounding code caused it to move from minor annoyance to catastrophic.  This moves us to a stricter mode where such errors are not allowed at all.
Copy link
Contributor

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally this would have made #606 fail

@giordano giordano merged commit bdf243e into franklin Jul 10, 2024
2 checks passed
@giordano giordano deleted the sf/we_want_those_errors branch July 10, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants