-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHA3 xof shake128 and shake256 #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
These changes seem to have broken the tests, so first resolve that. Next, you'll need to implement a number of tests to ensure that the implementation is correct. Then I can review again.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
==========================================
- Coverage 99.00% 98.14% -0.87%
==========================================
Files 8 9 +1
Lines 402 484 +82
==========================================
+ Hits 398 475 +77
- Misses 4 9 +5
☔ View full report in Codecov by Sentry. |
Thanks for the fast feedback, i fixed the issues and will add some tests regarding shake soon. |
Hi @staticfloat I added some basic testing. |
Co-authored-by: Elliot Saba <[email protected]>
LGTM! Thanks! |
Hi @staticfloat,
i added some implementations of the extended output function shake, since i needed them for my work. I thought this module could take advantage of it.
This is my first pull request, so i'm sorry if anything is not along the usual workflow. Plealse give me feedback!
kind regards.