Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHA3 xof shake128 and shake256 #92

Merged
merged 8 commits into from
Nov 11, 2023
Merged

SHA3 xof shake128 and shake256 #92

merged 8 commits into from
Nov 11, 2023

Conversation

immoschuett
Copy link
Contributor

Hi @staticfloat,

i added some implementations of the extended output function shake, since i needed them for my work. I thought this module could take advantage of it.

This is my first pull request, so i'm sorry if anything is not along the usual workflow. Plealse give me feedback!

kind regards.

Copy link
Member

@staticfloat staticfloat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

These changes seem to have broken the tests, so first resolve that. Next, you'll need to implement a number of tests to ensure that the implementation is correct. Then I can review again.

src/SHA.jl Outdated Show resolved Hide resolved
src/SHA.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e1af7dd) 99.00% compared to head (241d62b) 98.14%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   99.00%   98.14%   -0.87%     
==========================================
  Files           8        9       +1     
  Lines         402      484      +82     
==========================================
+ Hits          398      475      +77     
- Misses          4        9       +5     
Files Coverage Δ
src/SHA.jl 100.00% <ø> (ø)
src/shake.jl 93.90% <93.90%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@immoschuett
Copy link
Contributor Author

Thanks for the fast feedback, i fixed the issues and will add some tests regarding shake soon.

@immoschuett
Copy link
Contributor Author

Hi @staticfloat

I added some basic testing.
Yet, I did not add any documentation, only comments, but I can work on that later on. I wanted to wait for your first review, because i expect, that some Structs from SHAKE can/should be moved somwhere else.

src/shake.jl Outdated Show resolved Hide resolved
src/shake.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
src/shake.jl Outdated Show resolved Hide resolved
@staticfloat
Copy link
Member

LGTM! Thanks!

@staticfloat staticfloat merged commit 176baaa into JuliaCrypto:master Nov 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants