Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Mooncake caching #513

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Improve Mooncake caching #513

merged 3 commits into from
Sep 30, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 30, 2024

DI extensions

  • Mooncake: use preparation to allocate tangent objects with the correct tangent type

@willtebbutt care to take a look?

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.69%. Comparing base (7a09754) to head (93d13bf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...MooncakeExt/DifferentiationInterfaceMooncakeExt.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
- Coverage   98.71%   98.69%   -0.03%     
==========================================
  Files         105      105              
  Lines        4523     4529       +6     
==========================================
+ Hits         4465     4470       +5     
- Misses         58       59       +1     
Flag Coverage Δ
DI 98.87% <95.45%> (-0.04%) ⬇️
DIT 98.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review September 30, 2024 10:42
@gdalle gdalle merged commit 7ee5859 into main Sep 30, 2024
59 checks passed
@gdalle gdalle deleted the gd/mooncake_caching branch September 30, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants