Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch Zygote nothing returns and give an informative error message #604

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Catch Zygote nothing returns and give an informative error message #604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ationInterface/ext/DifferentiationInterfaceZygoteExt/DifferentiationInterfaceZygoteExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ function DI.value_and_gradient!(
f, grad, prep::NoGradientPrep, backend::AutoZygote, x, contexts::Vararg{Constant,C}
) where {C}
y, new_grad = DI.value_and_gradient(f, prep, backend, x, contexts...)
if isnothing(new_grad)
error("Exact zero gradient detected via Zygote `nothing` derivative. This is indicative of a coding error making the function `f` not a function of the `x` being differentiated")
end
return y, copyto!(grad, new_grad)
end

Expand Down
Loading