-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor gMAM #25
Refactor gMAM #25
Conversation
@reykboerner What is the reason that we have to re-interpolate the path after every optimization path? I guess it ensures continuity of the path? It would be nice if we could enforce this within the Optimizer of Optim.jl. Not sure if it possible tho. |
.JuliaFormatter.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain what this does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha yes sorry. Maybe I shouldn't have committed this. This is a configuration file that format the code to the SciML style guidelines. It works with JuliaFormatter.jl. Feel free to delete this. We could opt to add a CI who automatically formats the code. But I know that Juliadynamics is also still arguing what style they want to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll omit it now and we can discuss the CI in our next meeting.
Hi @oameye, are there any changes here that change what |
All the changes should be cosmetic. I just refactored and reformatted the code. The main changes are:
|
Great, thanks for the additional description! Merging this now. |
No description provided.