Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore -> ignore_derivatives #108

Merged
merged 2 commits into from
Jan 8, 2024
Merged

ignore -> ignore_derivatives #108

merged 2 commits into from
Jan 8, 2024

Conversation

benedict-96
Copy link
Collaborator

Replaced ignore with ignore_derivatives (see #85).

I'm also not quite sure why we need this routine, because ignore_derivatives does as the name suggests only compute the forward pass while not outputting the pullback; it should be equivalent to simply calling the function: https://github.com/JuliaDiff/ChainRulesCore.jl/blob/83366a5b2a1415dcae9b39521ae4c8b887bb0d5c/src/ignore_derivatives.jl#L8

@benedict-96 benedict-96 requested a review from michakraus January 8, 2024 10:02
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d42e956) 68.27% compared to head (a29444f) 68.27%.

Files Patch % Lines
src/training_method/variational_method.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   68.27%   68.27%           
=======================================
  Files          96       96           
  Lines        2440     2440           
=======================================
  Hits         1666     1666           
  Misses        774      774           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michakraus michakraus merged commit 1fe3115 into main Jan 8, 2024
11 of 15 checks passed
@michakraus michakraus deleted the ignore_derivative branch January 8, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants