Skip to content

More tests for sparse matrix dimension checks #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kshyatt
Copy link
Member

@kshyatt kshyatt commented Jun 23, 2025

No description provided.

@kshyatt kshyatt requested a review from maleadt June 23, 2025 16:28
@kshyatt kshyatt added cuda libraries Stuff about CUDA library wrappers. tests Adds or changes tests. labels Jun 23, 2025
Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/test/libraries/cusparse/bmm.jl b/test/libraries/cusparse/bmm.jl
index bd27f03b9..feadbf21b 100644
--- a/test/libraries/cusparse/bmm.jl
+++ b/test/libraries/cusparse/bmm.jl
@@ -15,24 +15,24 @@ if CUSPARSE.version() ≥ v"11.7.2"
     α = rand(elty) 
     β = rand(elty) 
 
-    @testset "Dimension checks" begin
-        A1 = CuSparseMatrixCSR{elty}(sprand(elty, m, k, p))
-        A2 = copy(A1)
-        A2.nzVal = CUDA.rand(elty, size(A2.nzVal)...)
-        A = cat(A1, A2; dims=3)
+        @testset "Dimension checks" begin
+            A1 = CuSparseMatrixCSR{elty}(sprand(elty, m, k, p))
+            A2 = copy(A1)
+            A2.nzVal = CUDA.rand(elty, size(A2.nzVal)...)
+            A = cat(A1, A2; dims = 3)
 
-        B = CUDA.rand(elty, k, n, 2)
-        C = CUDA.rand(elty, m, n, 3)
+            B = CUDA.rand(elty, k, n, 2)
+            C = CUDA.rand(elty, m, n, 3)
 
-        @test_throws ArgumentError("C must have same batch-dimension as max(size(A,3)=$(size(A,3)), size(B,3)=$(size(B,3))), got $(size(C,3)).") CUSPARSE.bmm!('N', 'N', α, A, B, β, C, 'O') 
-        
-        C = CUDA.rand(elty, m, 1, 2)
-        @test_throws ArgumentError("bmm! does not work for n==1 and b>1 due to CUDA error.") CUSPARSE.bmm!('N', 'N', α, A, B, β, C, 'O') 
+            @test_throws ArgumentError("C must have same batch-dimension as max(size(A,3)=$(size(A, 3)), size(B,3)=$(size(B, 3))), got $(size(C, 3)).") CUSPARSE.bmm!('N', 'N', α, A, B, β, C, 'O')
 
-        C = CUDA.rand(elty, m, n, 2)
-        B = CUDA.rand(elty, k+1, n, 2)
-        @test_throws DimensionMismatch("B has dimensions $(size(B)) but needs ($k,$n)") CUSPARSE.bmm!('N', 'N', α, A, B, β, C, 'O') 
-    end
+            C = CUDA.rand(elty, m, 1, 2)
+            @test_throws ArgumentError("bmm! does not work for n==1 and b>1 due to CUDA error.") CUSPARSE.bmm!('N', 'N', α, A, B, β, C, 'O')
+
+            C = CUDA.rand(elty, m, n, 2)
+            B = CUDA.rand(elty, k + 1, n, 2)
+            @test_throws DimensionMismatch("B has dimensions $(size(B)) but needs ($k,$n)") CUSPARSE.bmm!('N', 'N', α, A, B, β, C, 'O')
+        end
 
     @testset "C = αAB + βC" begin
         A1 = CuSparseMatrixCSR{elty}(sprand(elty, m, k, p))
diff --git a/test/libraries/cusparse/generic.jl b/test/libraries/cusparse/generic.jl
index 9c5ebcdca..80a8d7245 100644
--- a/test/libraries/cusparse/generic.jl
+++ b/test/libraries/cusparse/generic.jl
@@ -20,14 +20,14 @@ if CUSPARSE.version() >= v"11.4.1"
         dA = CuSparseMatrixCSR(dA)
         mv!('N', one(T), dA, dx, zero(T), dy, 'O')
         @test Array(dy) ≈ A * x
-        
-        A_bad = sprand(T, m+1, m, 0.1)
+
+        A_bad = sprand(T, m + 1, m, 0.1)
         dA_bad = adapt(CuArray, A_bad)
-        @test_throws DimensionMismatch("Y must have length $(m+1), but has length $m") mv!('N', one(T), dA_bad, dx, zero(T), dy, 'O')
+        @test_throws DimensionMismatch("Y must have length $(m + 1), but has length $m") mv!('N', one(T), dA_bad, dx, zero(T), dy, 'O')
 
-        A_bad = sprand(T, m, m+1, 0.1)
+        A_bad = sprand(T, m, m + 1, 0.1)
         dA_bad = adapt(CuArray, A_bad)
-        @test_throws DimensionMismatch("X must have length $(m+1), but has length $m") mv!('N', one(T), dA_bad, dx, zero(T), dy, 'O')
+        @test_throws DimensionMismatch("X must have length $(m + 1), but has length $m") mv!('N', one(T), dA_bad, dx, zero(T), dy, 'O')
     end
 end
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda libraries Stuff about CUDA library wrappers. tests Adds or changes tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant