-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a function to reset the compile cache #508
base: master
Are you sure you want to change the base?
Conversation
Huh, just noticed this: Lines 152 to 160 in d9b8f47
I suppose that's already the same thing, except it doesn't take care of the additional versioning scheme with 1.9+? Should I delete this or close this PR? I probably should get the runtime lock at least. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #508 +/- ##
==========================================
- Coverage 82.28% 74.96% -7.33%
==========================================
Files 23 24 +1
Lines 3082 3259 +177
==========================================
- Hits 2536 2443 -93
- Misses 546 816 +270
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
The failure on julia master seems to be due to #506 |
Yeah, I'm not sure why. When trying in isolation, reading invalid bitcode does throw a proper error. I'm not sure why it suddenly exits there sometimes...
That may be a good thing to add. Regarding the usefulness of this PR, I'm not sure it's worth the changes right now. Renaming |
Well, I can pretty reliably reproduce this with AVR, would you be interested in a MWE for that?
Right, that's why none of this is exported. It's just useful to have a function for this that can be called in both There are also various places where Lines 136 to 139 in d9b8f47
which may be replaced with a call to |
Yes, please! |
It can happen sometimes that a bad LLVM module makes it into the compile cache, which is really annoying to debug due to the very unhelpful LLVM error this causes (the
try
/catch
here never fires, as LLVM seems to kill the process). The easiest fix is just to get a clean slate, by deleting the compile cache in the scratch space. This PR adds a function to do just that - it's already been useful in debugging a bad AVR runtime cache :)