Disable the vectorizer pipeline. #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #516 +/- ##
==========================================
- Coverage 84.17% 83.83% -0.34%
==========================================
Files 24 24
Lines 3292 3292
==========================================
- Hits 2771 2760 -11
- Misses 521 532 +11
☔ View full report in Codecov by Sentry. |
|
|
Apparently SPIR-V also can't handle this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we may want some additional configurability here, let's quickly disable it now as our Legacy PM pipeline doesn't have vectorization passes, because we specifically disabled those. This results in compilation failures with Metal, but I'm sure not all GPU back-ends support arbitrary vector operations (or know how to legalize them).