Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more flexible FPU operator #161

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

wardvermeulen
Copy link
Collaborator

@wardvermeulen wardvermeulen commented Oct 11, 2023

This PR introduces more flexibility to the FPU operator as well as a ConfigError exception to handle misconfigurations of the kernel more easily.

The operator changed from GeneralFPUOp{M, N, K, CT, AT} to:

# mb, nb, kb are the base operator shapes (kb must be equal to 1 for now).
# M, N, K must be multiples of mb, nb, and kb respectively.
abstract type GeneralFPUOp{M, N, K, mb, nb, kb, CT, AT} end

Here, mb, nb, and kb are the internal base operator shapes that used to be equal to 4, 8, and 1 respectively by default.

src/config.jl Outdated Show resolved Hide resolved
@thomasfaingnaert
Copy link
Member

CI failure is because I changed the benchmark keys to include the base operator shape.

@thomasfaingnaert thomasfaingnaert merged commit e78e1e7 into JuliaGPU:master Oct 24, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants