-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to pending Enzymecore changes #519
Conversation
@@ -253,7 +255,7 @@ function gpu_rev( | |||
end | |||
|
|||
function EnzymeRules.augmented_primal( | |||
config::Config, | |||
config::RevConfig, | |||
func::Const{<:Kernel}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need those kinds of changes with an abstract Config type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forward mode rules changed fairly fundamentally, so we'll definitely still need these changes
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Can we re-trigger the CI with Enzyme 0.13 released |
KernelAbstractions.jl/test/Project.toml Line 13 in d9062a3
|
@maleadt okay this passes locally confirmed for me. This is probably the better place to bump first, if you are willing to give it the thumbs up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superficially LGTM.
Going to merge and hopefully check CUDA.jl success, then we can cut various releases if all is green |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 7 7
Lines 528 528
=====================================
Misses 528 528 ☔ View full report in Codecov by Sentry. |
No description provided.