Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Replaces #236)
Base.Math.log1p
calculation relies on two procedures , log_proc1 and log_proc2 from the literature Tang (1990). The current implementation upscales toFloat64
internally and as such is incompatible with Metal.See also relevant discussions #234, #236
This PR ports
log1pf
from openlibmError Analysis (ULP) (Ran on CPU)
This implementation v. the original C implementation (
Float32
)This implementation v.
Base.Math.log1p(::Float64)
This implementation v.
Base.Math.log1p(::Float32)
Error Analysis (ULP) (Ran on GPU using 100,000 points)
v.
Base.Math.log1p(::Float64)
v.
Base.Math.log1p(::Float32)