Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace current_device() with device() #366

Merged
merged 6 commits into from
Jun 18, 2024
Merged

Conversation

christiangnrd
Copy link
Contributor

Addresses

FWIW, oneAPI.jl also uses device, so I guess it makes sense to switch Metal.jl to that too.

from #359 (comment).

Replaces all uses of current_device() with device() and aliases the old name to make this non-breaking.

Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change is also good to not confuse with CUDA.jl's current_device() which returns the library-bound device (and can be nothing).

The scripts I added in #368 now also need adjustment.

src/state.jl Outdated Show resolved Hide resolved
src/deprecated.jl Outdated Show resolved Hide resolved
Co-authored-by: Tim Besard <[email protected]>
@maleadt maleadt merged commit e3a8ed2 into JuliaGPU:main Jun 18, 2024
1 check failed
@christiangnrd christiangnrd deleted the device branch June 18, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants