Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export MTL #392

Merged
merged 19 commits into from
Jul 24, 2024
Merged

Don't export MTL #392

merged 19 commits into from
Jul 24, 2024

Conversation

christiangnrd
Copy link
Contributor

@christiangnrd christiangnrd commented Jul 18, 2024

As discussed in #359 (comment).

TODO:

  • Maybe remove Unexport CPUStorage from MTL?
  • Fix storage mode output of MtlArrays

@christiangnrd christiangnrd added the breaking Issues or PRs that would require a breaking release when resolved. label Jul 18, 2024
lib/mps/MPS.jl Outdated Show resolved Hide resolved
src/Metal.jl Outdated Show resolved Hide resolved
test/execution.jl Outdated Show resolved Hide resolved
@christiangnrd
Copy link
Contributor Author

The scripts test isn't failing on my machine and I don't know if it's related.

@maleadt
Copy link
Member

maleadt commented Jul 19, 2024

The scripts test isn't failing on my machine and I don't know if it's related.

ERROR: LoadError: UndefVarError: air_support not defined

That seems related?

@maleadt
Copy link
Member

maleadt commented Jul 19, 2024

The scripts test isn't failing on my machine and I don't know if it's related.

You realize the tests don't run by default?

if get(ENV, "BUILDKITE_PIPELINE_NAME", "") != "Metal.jl"
@warn "Skipping script tests"

I'll push a fix.

@christiangnrd
Copy link
Contributor Author

I didn't when I wrote that comment but noticed this morning when I started looking into it. I turned the errors into failures and was going to look into it more later in the day.

Comment on lines 3 to 4
# possible values: "PrivateStorage", "SharedStorage", "ManagedStorage"
#default_storage = "PrivateStorage"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the preference needs to be renamed. storage = PrivateStorage seems redundant? Maybe we should even use simpler, lower-case identifiers instead, like in CUDA.jl (private, managed, shared).

@christiangnrd
Copy link
Contributor Author

This should be ready to merge after final review.

@maleadt maleadt merged commit a07675d into JuliaGPU:main Jul 24, 2024
1 check passed
@christiangnrd christiangnrd deleted the noMTL branch July 24, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Issues or PRs that would require a breaking release when resolved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants