-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't export MTL
#392
Don't export MTL
#392
Conversation
The scripts test isn't failing on my machine and I don't know if it's related. |
That seems related? |
You realize the tests don't run by default? Lines 7 to 9 in 116b1bf
I'll push a fix. |
I didn't when I wrote that comment but noticed this morning when I started looking into it. I turned the errors into failures and was going to look into it more later in the day. |
LocalPreferences.toml
Outdated
# possible values: "PrivateStorage", "SharedStorage", "ManagedStorage" | ||
#default_storage = "PrivateStorage" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the preference needs to be renamed. storage = PrivateStorage
seems redundant? Maybe we should even use simpler, lower-case identifiers instead, like in CUDA.jl (private
, managed
, shared
).
This should be ready to merge after final review. |
Add docstrings
As discussed in #359 (comment).
TODO:
Maybe removeUnexportCPUStorage
fromMTL
?