Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make lu results have same storage mode as input #435

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Make lu results have same storage mode as input #435

merged 5 commits into from
Sep 30, 2024

Conversation

christiangnrd
Copy link
Contributor

Noticed while reviewing #313.

maleadt
maleadt reviewed Sep 27, 2024
View reviewed changes
test/mps/linalg.jl Outdated Show resolved Hide resolved
tgymnich
tgymnich reviewed Sep 27, 2024
View reviewed changes
lib/mps/linalg.jl Outdated Show resolved Hide resolved
@christiangnrd
Copy link
Contributor Author

Turns out the code was wrong, but so were the tests. Should be fixed now.

@maleadt maleadt added enhancement libraries Things about libraries and how we use them. labels Sep 30, 2024
@maleadt maleadt merged commit 3bbda32 into main Sep 30, 2024
1 check passed
@maleadt maleadt deleted the lustoragemode branch September 30, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgymnich tgymnich tgymnich approved these changes

@maleadt maleadt maleadt left review comments

Assignees
No one assigned
Labels
libraries Things about libraries and how we use them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christiangnrd @maleadt @tgymnich