Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in random tests #514

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix typo in random tests #514

merged 1 commit into from
Jan 6, 2025

Conversation

christiangnrd
Copy link
Contributor

No description provided.

@christiangnrd christiangnrd changed the title Fix typo in tests Fix typo in random tests Jan 4, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metal Benchmarks

Benchmark suite Current: 2be2785 Previous: de8eed5 Ratio
private array/construct 27298.5 ns 26726.14285714286 ns 1.02
private array/broadcast 465375 ns 467625 ns 1.00
private array/random/randn/Float32 805395.5 ns 925917 ns 0.87
private array/random/randn!/Float32 655333 ns 593500 ns 1.10
private array/random/rand!/Int64 558208 ns 550042 ns 1.01
private array/random/rand!/Float32 596000 ns 558625 ns 1.07
private array/random/rand/Int64 764791.5 ns 858229 ns 0.89
private array/random/rand/Float32 578583 ns 831083 ns 0.70
private array/copyto!/gpu_to_gpu 563625 ns 548209 ns 1.03
private array/copyto!/cpu_to_gpu 832916 ns 688458.5 ns 1.21
private array/copyto!/gpu_to_cpu 665104 ns 626000 ns 1.06
private array/accumulate/1d 1327854 ns 1426625 ns 0.93
private array/accumulate/2d 1381166 ns 1524853.5 ns 0.91
private array/iteration/findall/int 2067729.5 ns 2284896 ns 0.90
private array/iteration/findall/bool 1821417 ns 2055500 ns 0.89
private array/iteration/findfirst/int 1686541 ns 1826500 ns 0.92
private array/iteration/findfirst/bool 1647958 ns 1739770.5 ns 0.95
private array/iteration/scalar 3915083 ns 2446687 ns 1.60
private array/iteration/logical 3175916.5 ns 3543000 ns 0.90
private array/iteration/findmin/1d 1756042 ns 1920312.5 ns 0.91
private array/iteration/findmin/2d 1331166.5 ns 1433354.5 ns 0.93
private array/reductions/reduce/1d 1034125.5 ns 929542 ns 1.11
private array/reductions/reduce/2d 656979.5 ns 715208 ns 0.92
private array/reductions/mapreduce/1d 1047708.5 ns 1000417 ns 1.05
private array/reductions/mapreduce/2d 658958 ns 707604.5 ns 0.93
private array/permutedims/4d 2528042 ns 2685542 ns 0.94
private array/permutedims/2d 1006833 ns 1095645.5 ns 0.92
private array/permutedims/3d 1586416.5 ns 1858833.5 ns 0.85
private array/copy 585625 ns 839083 ns 0.70
latency/precompile 5735779458 ns 5818530541.5 ns 0.99
latency/ttfp 3029208458 ns 3076733499.5 ns 0.98
latency/import 1139343833 ns 1161722437.5 ns 0.98
integration/metaldevrt 683583 ns 769000 ns 0.89
integration/byval/slices=1 1630042 ns 1682812.5 ns 0.97
integration/byval/slices=3 11664833.5 ns 20107416 ns 0.58
integration/byval/reference 1548500 ns 1668458.5 ns 0.93
integration/byval/slices=2 2575542 ns 2862250 ns 0.90
kernel/indexing 460500 ns 465667 ns 0.99
kernel/indexing_checked 455875 ns 471958 ns 0.97
kernel/launch 8000 ns 8167 ns 0.98
metal/synchronization/stream 14833 ns 15000 ns 0.99
metal/synchronization/context 15084 ns 15292 ns 0.99
shared array/construct 26513.916666666664 ns 26149.25 ns 1.01
shared array/broadcast 471333 ns 466375 ns 1.01
shared array/random/randn/Float32 816750 ns 917458 ns 0.89
shared array/random/randn!/Float32 659625 ns 595833 ns 1.11
shared array/random/rand!/Int64 557958 ns 550375 ns 1.01
shared array/random/rand!/Float32 599084 ns 558416.5 ns 1.07
shared array/random/rand/Int64 769000 ns 855708 ns 0.90
shared array/random/rand/Float32 613875 ns 809708 ns 0.76
shared array/copyto!/gpu_to_gpu 86250 ns 81250 ns 1.06
shared array/copyto!/cpu_to_gpu 89375 ns 82417 ns 1.08
shared array/copyto!/gpu_to_cpu 77792 ns 82125 ns 0.95
shared array/accumulate/1d 1335791.5 ns 1417292 ns 0.94
shared array/accumulate/2d 1370187.5 ns 1506208 ns 0.91
shared array/iteration/findall/int 1829375 ns 2042854.5 ns 0.90
shared array/iteration/findall/bool 1564542 ns 1762250.5 ns 0.89
shared array/iteration/findfirst/int 1385792 ns 1513750.5 ns 0.92
shared array/iteration/findfirst/bool 1377500 ns 1440125 ns 0.96
shared array/iteration/scalar 160458 ns 160334 ns 1.00
shared array/iteration/logical 2964062.5 ns 3301709 ns 0.90
shared array/iteration/findmin/1d 1482270.5 ns 1580791 ns 0.94
shared array/iteration/findmin/2d 1362042 ns 1457833 ns 0.93
shared array/reductions/reduce/1d 737625 ns 692271 ns 1.07
shared array/reductions/reduce/2d 651125 ns 700958.5 ns 0.93
shared array/reductions/mapreduce/1d 732666.5 ns 718458.5 ns 1.02
shared array/reductions/mapreduce/2d 664167 ns 717104.5 ns 0.93
shared array/permutedims/4d 2538937.5 ns 2679896 ns 0.95
shared array/permutedims/2d 1013417 ns 1119959 ns 0.90
shared array/permutedims/3d 1587666 ns 1852000.5 ns 0.86
shared array/copy 246417 ns 210584 ns 1.17

This comment was automatically generated by workflow using github-action-benchmark.

@christiangnrd christiangnrd force-pushed the christiangnrd-patch-1 branch from 99a99ef to 269bf1f Compare January 4, 2025 18:58
@maleadt maleadt force-pushed the christiangnrd-patch-1 branch from 269bf1f to 2be2785 Compare January 6, 2025 07:39
@maleadt maleadt merged commit 6ac7f3c into main Jan 6, 2025
2 checks passed
@maleadt maleadt deleted the christiangnrd-patch-1 branch January 6, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants