-
Notifications
You must be signed in to change notification settings - Fork 43
Use the platform OpenCL library on Apple. #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #221 +/- ##
===========================================
- Coverage 70.45% 53.33% -17.13%
===========================================
Files 3 3
Lines 132 135 +3
===========================================
- Hits 93 72 -21
- Misses 39 63 +24 ☔ View full report in Codecov by Sentry. |
Hey! May I ask, is the incentive for the PR to support Apple GPUs? |
Yes, correct. But unlikely to happen, as stated above. |
I think BDA can support this as well. :) Would be nice if someone with a Mac could test though. |
Well, if someone is interested in trying, the Launch julia with |
Sadly not. Homebrew's build of mesa's rusticl depends on homebrew's own libLLVM, which conflicts with the one Julia loads:
If you want to proceed here, I think we'll need a JLL build of mesa that's either compatible with Julia's LLVM, or statically links its preferred version of the library. |
I'll open an issue for now! |
Fixes #205
I'm not inclined to merge this, though. Apple has deprecated OpenCL, only supporting v1.2, which is ancient. I'll leave this up in case somebody really needs this, and wants to finish this. That would either involve making everything compatible with OpenCL v1.2, or introducing an opt-in preference to use the system OpenCL platform for backwards compatibility.