build on approx_log_evidence introduced in AbstractGPs 0.5.17
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hadn't looked so good to the CI 😅 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 93.35% 0.35% -93.01%
==========================================
Files 4 5 +1
Lines 286 281 -5
==========================================
- Hits 267 1 -266
- Misses 19 280 +261
☔ View full report in Codecov by Sentry. |
|
@willtebbutt any idea what's going on with the Julia 1 tests? 🤔 |
|
Hmm it looks like something going wrong in ChainRules / Zygote, but I definitely couldn't tell you what 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates the
approx_lmldefined in this package in favour ofAbstractGPs.approx_log_evidence(see JuliaGaussianProcesses/AbstractGPs.jl#361).