Add Cone primitive #257
Merged
Add Cone primitive #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffreyer
commented
Apr 16, 2025
Comment on lines
+74
to
+77
| # tip - this is undefined / should be all ring angles at once | ||
| # for rendering it is useful to define this as Vec3f(0), because tip normal | ||
| # has no useful value to contribute to the interpolated fragment normal | ||
| ns[end-1] = Vec3f(0) |
There was a problem hiding this comment.
This fixes seams on the mesh. The left mesh uses triangles where the tip vertex is duplicated for each triangle with a different normal (average of bottom normals). The right uses one (0,0,0) vertex at the tip:
You get the same seams with quads instead of triangles and even if you give the tip a finite radius, i.e. with a conical frustum. (?)
23 tasks
SimonDanisch
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to remove the mesh generation code in Makie that's used for arrows and add replacements as GeometryPrimitives here. This is coupled with MakieOrg/Makie.jl#4925.
Currently this just adds
Cone()with the idea of simplifying the arrow components to full, closed meshes.