Allow for GeometryBasics v0.5 #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the moment this is just guesswork. @ffreyer could you help out a bit with this transition ? @SimonDanisch seems to be quite busy in the moment. |
|
Thanks to JuliaGeometry/GeometryBasics.jl#230 (comment) this kind of works now. Would love to have a review nevertheless. So we need a MetaMesh to feed into TetGen instead of a Mesh, so this breaking and will be v2.0. |
This will make the breaking less painful...
j-fu
changed the title
|
Ok, now it seems to be in a reasonable state. |
|
Will merge and release by end of this week if there is no further comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be important to do this close to the release of Makie v0.22 in order to avoid blocking updates. See #41