Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue brought up here #150 and here #303. To summarize, those issues both mention that
Blink
was not defined when usingloadurl
.This PR addresses the issue by loading
blink.js
andwebio.bundle.js
whenever content is loaded using a custom URL. This was achieved by passing the URL of the websocket server tocreateWindow
in main.js. This allowed the required JS files to be loaded whenever the Electron BrowserWindow does a navigation (i.e. when Julia callsloadurl
or creates a window with :url defined).Also, this PR fixes a warning that would fire every time the
WebSocket
would reconnect or wheneverblink.js
was reloaded. The warning was being fired from here:Finally, I saw this
![Screenshot 2024-01-28 at 11 42 21 PM](https://private-user-images.githubusercontent.com/9089108/300370191-b1b808fe-3a2c-4c35-a144-7cdeb56bfa85.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMjQzMTgsIm5iZiI6MTczOTMyNDAxOCwicGF0aCI6Ii85MDg5MTA4LzMwMDM3MDE5MS1iMWI4MDhmZS0zYTJjLTRjMzUtYTE0NC03Y2RlYjU2YmZhODUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMDEzMzM4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTFhNDIzNzQyOWEzZThjZjlkMThhNjljOWEyMTY2ZTdmOWRmYzhjMTk2NDRjZTlmMDQ3MTY2ZDBkOTM2MzcwYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.3JoSN_lrQmLKrvDSvc6n9gOw-XPRwVt-w-kvjgel_xQ)
#TODO
insrc/AtomShell/window.jl
that might be relevant to these changes:Is there any way I can address that
#TODO
in this PR?