-
Notifications
You must be signed in to change notification settings - Fork 98
add non-allocating enumerate_paths! #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Bump |
the failures seem to be only in JuliaFormating tests. Do you mind running the formater? |
Ok, thats done. I have a few requests:
|
I am not really a core part of the team, so I can not address these requests, but I am in favor of the changes you are requesting. @gdalle , are you a good person to tag on this (see previous comment)? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
=======================================
Coverage 97.30% 97.31%
=======================================
Files 117 117
Lines 6948 6962 +14
=======================================
+ Hits 6761 6775 +14
Misses 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR adds an in-place version of
enumerate_paths
-enumerate_paths!
, thatenumerate_paths
now calls itself after making the required allocations.This can greatly improve performance where you need to call it many times. I also removed allocations in
enumerate_paths
functions, such as allocations ofVector{Int}
whereUnitRange
works fine in its place.(This may need a specific test, although it will run in the current tests anyway - I can write that if its considered to be merged)