-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect the alignment attribute of functions. #186
Conversation
…pport calls to function pointer calls to member functions (which need to be aligned to 2, and the generated code crashes if this happens to be not the case)
The test needs to be disabled for windows |
Some test_dtor seem to still need fixing. And run |
…ate #define for this, which is a no-op on MSVC Given that this occurs in several tests, and the MSVC tests have error-on-warning, this is a comment rather than a #warning
7ef458f
to
0f410a3
Compare
fd4d5e8
to
455a8ee
Compare
For the remaining failures:
|
Yes, building with no-strict-aliasing should be fine, since the output isn't tbaa-safe anyways (I think there is an issue about that). I'd guess that it considers an aligned function to be a different type than the loaded function type? No idea why test_char_sized_ptr_math_decr would be affected, since this change would fail on msvc anyways if it affected the code. Hopefully it will pass next time. EDIT: #169 |
This is necessary to support calls to function pointer calls to member functions (which need to be aligned to 2, and the generated code crashes if this happens to be not the case)