Allow compressed data in R data files #308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225
Fixes #32
xref JuliaStats/RDatasets.jl#117
For those interested in the details: the 1.5.x-and-earlier version of FileIO checked
hasmagic
on the format, and if it was a recognized extension without "magic" then it blindly trusted the format. The rewrite does the same. However, it turns out that previouslyhasmagic
returnedfalse
if the format had a detection function rather than a set of magic bytes, whereas in my "cleaned up" implementation I only returnfalse
ifmagic
is literally empty. Hence the old version checked when the format was identifed via a list of bytes but not when it was detected by a registered detection function.For the record, I think the old approach wasn't really correct: if you've registered a detection function, that should be the same as registering explicit bytes. But it's just another piece of havoc created by the rewrite which in retrospect clearly should have been FileIO 2. 😢