Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make excluded threadunsafe tests threadsafe #121

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@

Manifest.toml
6 changes: 3 additions & 3 deletions test/distributed_exec.jl
Original file line number Diff line number Diff line change
Expand Up @@ -160,12 +160,12 @@ function _getenv_include_thread_unsafe()
end
const _env_include_thread_unsafe = _getenv_include_thread_unsafe()
function include_thread_unsafe_tests()
if Threads.maxthreadid() > 1
if Threads.threadpoolsize(:default) > 1
if _env_include_thread_unsafe
return true
end
msg = "Skipping a thread-unsafe test because `Threads.maxthreadid() > 1`"
@warn msg Threads.maxthreadid()
msg = "Skipping a thread-unsafe test because `Threads.threadpoolsize(:default) > 1`"
@warn msg Threads.threadpoolsize(:default)
Test.@test_broken false
return false
end
Expand Down
Loading