Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Also try codespell #51706

Closed
wants to merge 42 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
dc102e2
Try using typos in CI
LilithHafner Oct 14, 2023
fe586bb
Apply suggestions from code review
DilumAluthge Oct 14, 2023
83926ab
Apply suggestions from code review
DilumAluthge Oct 14, 2023
18e1522
Apply suggestions from code review
DilumAluthge Oct 14, 2023
2c7b9b4
Set a 5-minute timeout (Apply suggestions from code review)
DilumAluthge Oct 14, 2023
4e25d37
Switch back to `permissions: {}` (Apply suggestions from code review)
DilumAluthge Oct 14, 2023
fc275a4
CI: Also try `codespell`
DilumAluthge Oct 14, 2023
3f3bb04
Fix a syntax error
DilumAluthge Oct 14, 2023
6402c53
Add a short timeout
DilumAluthge Oct 14, 2023
e7081ff
Add a `codespell` ignore file
DilumAluthge Oct 14, 2023
39cb8f5
Use the `codespell` ignore file
DilumAluthge Oct 14, 2023
fbaf294
`codespell`: ignore `ans`
DilumAluthge Oct 14, 2023
babaf98
`codespell`: ignore `egal`
DilumAluthge Oct 14, 2023
ed37255
`codespell`: ignore `findn`
DilumAluthge Oct 14, 2023
df42a23
`codespell`: ignore `whos`
DilumAluthge Oct 14, 2023
c9499d2
`codespell`: ignore `caf`
DilumAluthge Oct 14, 2023
9c7fde7
`codespell`: ignore `dout`
DilumAluthge Oct 14, 2023
57b08d1
`codespell`: ignore `afile`
DilumAluthge Oct 14, 2023
646f53b
`codespell`: ignore `te`
DilumAluthge Oct 14, 2023
63fcbbe
`codespell`: ignore `fo`
DilumAluthge Oct 14, 2023
3203762
Add a separate `codespell` job for assembly files
DilumAluthge Oct 14, 2023
66ff6f2
Add a separate `codespell` ignore file for assembly
DilumAluthge Oct 14, 2023
0ec1ca3
Use the separate `codespell` ignore file for assembly
DilumAluthge Oct 14, 2023
29297a6
`codespell`: ignore `seh` and `SEH` in assembly files
DilumAluthge Oct 14, 2023
c252a5b
Add some more file extensions: `*.h`, `*.iss`, `*.rtf`, and `*.toml`
DilumAluthge Oct 14, 2023
78d259b
Different file extensions should have different `codespell` ignore files
DilumAluthge Oct 14, 2023
1c961dd
Different file extensions should have different `codespell` ignore files
DilumAluthge Oct 14, 2023
9fa7ba0
Different file extensions should have different `codespell` ignore files
DilumAluthge Oct 14, 2023
2c5037d
Different file extensions should have different `codespell` ignore files
DilumAluthge Oct 14, 2023
ce3f9c5
Different file extensions should have different `codespell` ignore files
DilumAluthge Oct 14, 2023
6e40eb1
Use a GitHub Actions job matrix
DilumAluthge Oct 14, 2023
55470a3
Create .codespell.scm.ignore
DilumAluthge Oct 14, 2023
afa7ce8
Give Scheme files their own job in the `codespell` matrix
DilumAluthge Oct 14, 2023
4f72c4e
Put C source files into their own `codespell` job
DilumAluthge Oct 14, 2023
226e10a
Put C source files into their own `codespell` job
DilumAluthge Oct 14, 2023
cac995f
Put `.cpp` files into their own `codespell` job
DilumAluthge Oct 14, 2023
973648d
Put `.cpp` files into their own `codespell` job
DilumAluthge Oct 14, 2023
7d9c5aa
Need to rename a file (now that we use GitHub Actions job matrices)
DilumAluthge Oct 14, 2023
35eb941
Put `.toml` files in their own `codespell` job
DilumAluthge Oct 14, 2023
59d2f5b
Put `.toml` files in their own `codespell` job
DilumAluthge Oct 14, 2023
4ec4392
Put `.rtf` files in their own `codespell` job
DilumAluthge Oct 14, 2023
8cd06a7
Put `.rtf` files in their own `codespell` job
DilumAluthge Oct 14, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .codespell.S.ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
seh
SEH
1 change: 1 addition & 0 deletions .codespell.c.ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

1 change: 1 addition & 0 deletions .codespell.cpp.ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

1 change: 1 addition & 0 deletions .codespell.ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

6 changes: 6 additions & 0 deletions .codespell.jl.ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
afile
dout
egal
fo
te
whos
3 changes: 3 additions & 0 deletions .codespell.md.ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
ans
caf
findn
1 change: 1 addition & 0 deletions .codespell.rtf.ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

1 change: 1 addition & 0 deletions .codespell.scm.ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

1 change: 1 addition & 0 deletions .codespell.toml.ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

50 changes: 50 additions & 0 deletions .github/workflows/SpellCheck.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
name: Spell Check

permissions: {}

on: [pull_request]

jobs:
typos-check:
name: Spell Check with Typos
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- name: Checkout the JuliaLang/julia repository
uses: actions/checkout@v4
with:
persist-credentials: false
- name: Check spelling
uses: crate-ci/typos@master
codespell:
# https://github.com/codespell-project/codespell
# This is a catch-all job to cover file extensions that aren't in another job
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- run: pip install codespell
- run: codespell --skip='*.c,*.cpp,*.jl,*.md,*.rtf,*.scm,*.toml,*.S' --ignore-words=.codespell.ignore
codespell-file-extension:
runs-on: ubuntu-latest
timeout-minutes: 5
strategy:
fail-fast: false
matrix:
file-extension:
- 'c' # C files
- 'cpp' # C++ files
- 'jl' # Julia files
- 'md' # Markdown files
- 'rtf' # RTF (Rich Text Format) files
- 'scm' # Scheme (femtolisp) files
- 'toml' # TOML files
- 'S' # Assembly language files
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- run: pip install codespell
- run: find . -type f -name '*.${{ matrix.file-extension }}' -exec codespell --ignore-words=.codespell.jl.ignore {} \;
Loading