Adjoint for vectors may use trailing axes of the parent #52379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #52373, or at least the part that may be addressed here. After this, the first axis for an
Adjoint(parent::AbstractVector)
will be the second axis of theparent
. This will change the type of the axis where the parent array type specializesaxes(A, d)
. In the short term, this would improve type-stability in cases such aswhere the result is now concretely inferred instead of being a small
Union
.In principle, with JuliaArrays/StaticArrays.jl#916, this would make the axes of the adjoint of a
StaticVector
statically sized.