support x.y-nightly channel to allow testing nightlies on release branches
#1145
Conversation
| .to_string(); | ||
| let mut arch = parts.next().expect("Failed to parse channel name."); | ||
|
|
||
| // Check for the case where name is given as "x.y-latest-...", in which case |
There was a problem hiding this comment.
I'm not sure this is the most elegant way to do this.
|
I agree that this is a good feature to have. If we want to support the |
|
@LilithHafner I like the idea! @KristofferC maybe just change the PR for now to use Otherwise it looks good to me! That is the nice thing about Rust: if it compiles, it often is done ;) |
|
I prefer having it like this to have it consistent with e.g. the syntax in Github Actions. I don't think we make nightlies for other than the release branches. |
There was a problem hiding this comment.
Ok, I have to admit, I don't really care :) From my end this can merge either way. I also don't consider these kind of things part of any "public api" of Juliaup, so we can also change down the road.
Maybe we wait for a few more days if anyone else feels strongly about this, and then merge?
Think I finally managed to make a PR from my fork...