Skip to content

Conversation

@KristofferC
Copy link
Member

fixes #1076

Screen.Recording.2025-10-20.at.13.27.58.mov

developed with Claude 🤖

@KristofferC
Copy link
Member Author

I'm wondering if print(stderr, "\r\x1b[KChecking standard library notarization [$i/$total]") would become spammy if it is run during CI or soemthign

@IanButterworth
Copy link
Member

Yeah. Also I can't figure out why tests pass, because they check for .and(predicate::str::ends_with("done.\n"))

@KristofferC
Copy link
Member Author

KristofferC commented Oct 20, 2025

They don't pass (on mac at least) :P

Unexpected stderr, failed (var.starts_with("Checking for new Julia versions\nInstalling Julia 1.") && ((! var.contains(apple.darwin14)) || (var.contains(Checking standard library notarization) && var.ends_with("done.\n"))))

The log also looks quite spammy. Seems to be some julia precompilation interleaved with the output?

@IanButterworth
Copy link
Member

Oh right.. pre-coffee. I forgot this is mac-only on CI, and macOS sometimes fails for other reasons.

@IanButterworth
Copy link
Member

Seems we don't run CI tests on aarch64 macOS.. just check. That isn't good.

@IanButterworth
Copy link
Member

Seems we don't run CI tests on aarch64 macOS

Now we do. Needs an update from main

@KristofferC
Copy link
Member Author

Can't rebase because

Repository rule violations found Cannot force-push to this branch

-.-

@KristofferC
Copy link
Member Author

I removed that rule.

@IanButterworth
Copy link
Member

We can side step this if we can get this in #1320

@KristofferC
Copy link
Member Author

That seems preferable indeed

@davidanthoff
Copy link
Collaborator

I'm wondering if print(stderr, "\r\x1b[KChecking standard library notarization [$i/$total]") would become spammy if it is run during CI or soemthign

We already use the is_terminal crate in other parts of the code to detect whether things are running in a terminal or not, so that could be used here to switch between different output styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Checking standard library notarization" should be a spinner

3 participants