Skip to content

Wrap BNNS sublibrary with Clang and integrate with Random #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

christiangnrd
Copy link
Collaborator

@christiangnrd christiangnrd commented Jan 4, 2025

While only BNNS rng functionality is integrated with its equivalent Julia Package, all other BNNS symbols are available (but untested)

Not sure if this fully closes #36 but it's a step towards that.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 86.41975% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.43%. Comparing base (f53a97d) to head (3c1aa19).

Files with missing lines Patch % Lines
ext/RandomExt.jl 86.25% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   75.73%   78.43%   +2.70%     
==========================================
  Files           4        5       +1     
  Lines         239      320      +81     
==========================================
+ Hits          181      251      +70     
- Misses         58       69      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah
Copy link
Member

Should we see this all the way through?

@christiangnrd
Copy link
Collaborator Author

I’ll take a look in the coming days at the state of this PR but I’m not sure if it’s worth the effort considering most of the API was deprecated in macOS 15 in favour of BNNSGraph, which from my understanding only serves to load and run CoreML files.

@ViralBShah ViralBShah marked this pull request as draft May 30, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neural Net functions
2 participants