Merge pull request #143 from JuliaML/subtypes-fix

Fix for Julia version < v1.3
JuliaML · Jun 10, 2021 · 7f4d604 · 7f4d604
2 parents 1dc8c29 + 5dc8388
commit 7f4d604
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/Project.toml b/Project.toml
@@ -3,6 +3,7 @@ uuid = "30fc2ffe-d236-52d8-8643-a9d8f7c094a7"
 version = "0.7.1"
 
 [deps]
+InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
 LearnBase = "7f8f8fb0-2700-5f03-b4bd-41f8cfc144b6"
 Markdown = "d6f4376e-aef5-505a-96c1-9c027394607a"
 RecipesBase = "3cdcf5f2-1ef4-517c-9805-6587b60abb01"

diff --git a/src/LossFunctions.jl b/src/LossFunctions.jl
@@ -4,6 +4,7 @@ import Base.*
 using Base.Cartesian
 using Markdown
 using RecipesBase
+using InteractiveUtils: subtypes
 
 import LearnBase.AggMode
 import LearnBase.ObsDim

diff --git a/src/supervised.jl b/src/supervised.jl
@@ -189,4 +189,11 @@ for FUN in (:value, :deriv, :deriv2)
 end
 
 # convenient functor interface
-(loss::SupervisedLoss)(target::AbstractArray, output::AbstractArray) = value(loss, target, output)
+if VERSION ≥ v"1.3.0"
+    (loss::SupervisedLoss)(target::AbstractArray, output::AbstractArray) = value(loss, target, output)
+else
+    # add method manually to all subtypes
+    for L in Iterators.flatten([subtypes(DistanceLoss), subtypes(MarginLoss)])
+        (loss::L)(target::AbstractArray, output::AbstractArray) = value(loss, target, output)
+    end
+end