Some recursion tuning to allow more eager inference. #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise these code might be bad inferred before 1.11.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 87.87% 87.93% +0.06%
==========================================
Files 28 28
Lines 1880 1890 +10
==========================================
+ Hits 1652 1662 +10
Misses 228 228 ☔ View full report in Codecov by Sentry. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before julia 1.11, indirect recursion might cause unwanted type widening and leading to bad inference.
itp(...),gradient(itp, ...),hessian(itp, ...)would therefore become unstable ifitphas someNoInterpdim.This PR fix it, MWE has been added to Test.