Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entropy-regularised Gromov-Wasserstein #165
base: master
Are you sure you want to change the base?
Entropy-regularised Gromov-Wasserstein #165
Changes from 21 commits
2ef3e2b
11efd8c
3273976
0956c3b
c22d7e7
ff1a92c
267dfad
21609b0
9699e04
8510397
2f2428f
20d5885
df41c28
a7c1a38
19e4cab
56c4f9b
6e3ac4c
5c376ae
af2a493
6bc3127
a806f0f
f704397
71351b9
f2acc56
0635305
c3efe5a
39f0b36
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The multiplication with
-4
introduces additional allocations. I wonder if this could be avoided, e.g., by updating in-place or some additional cache.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dealt with now (in-place scaling of tmp)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
norm_plan
is never updated it seems but always set tosum(plan)
of the initial randomly initializedplan
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also avoid allocations here by writing:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial plan is taken to be the independent coupling and here we only consider the balanced problem, so
norm_plan
should not change. I agree however this is a special case of the unbalanced problem where it would not be constant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, done