-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RootFS] Update Rust to v1.77.1 #372
Conversation
To reproduce the error:
This apparently broke in ProgressMeter v1.10.0. CC @IanButterworth who authored timholy/ProgressMeter.jl#305 |
For reference, relevant code is at BinaryBuilderBase.jl/src/Sources.jl Lines 229 to 241 in 0b0372d
|
Sorry if I broke something. That PR should have just been a code move.. |
I'm not 100% it's that PR, but I confirm it works with ProgressMeter v1.9.0, so something in timholy/ProgressMeter.jl@v1.9.0...v1.10.0 affected it. |
Bisection points to timholy/ProgressMeter.jl#304 |
For reference, the progressbar was added in #240, but it was likely based on similar features present in Pkg: JuliaLang/Pkg.jl#177, JuliaLang/julia#26387 |
So, problem is BinaryBuilderBase.jl/src/Sources.jl Line 192 in 0b0372d
|
Breaking change in ProgressMeter worked around in #373. |
Companion PR to JuliaPackaging/Yggdrasil#8412